VR Teleop Support #1201
Open
VR Teleop Support #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liuyulinn can you resolve the conflict? Just accept the changes from main |
|
Also I think there are some incorrect code formatting changes. I also realize I have not been stringent enough on enforcing code formatting (e.g. PRs can still be merged even if the formatting is violated, I have not added github action for automatic formatting checks). Can you remove the changes to the files that were edited due to just formatting? I will make a separate PR to address formatting issues and require new PRs to follow it by using pre-commit hooks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VR teleop support and merge with latest main branch.