-
Notifications
You must be signed in to change notification settings - Fork 1
Add team-based channel analysis routes #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements routes for team-based channel analysis as requested in issue #175: - Added channel analysis page for initiating analysis - Added analysis result page with tabbed interface - Added analysis history page for viewing past analyses - Updated App.tsx with the new routes - Modified TeamChannelSelector to include analyze button 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
This commit addresses the issue where channel analyses were showing 0 messages, participants, threads, and reactions. The issue was that messages weren't being properly synchronized from Slack before analysis. Key changes: 1. Added a dedicated message sync endpoint for team integrations 2. Updated frontend to call this endpoint before analysis 3. Made apiUrl and getAuthHeaders public in IntegrationService for custom endpoint access 4. Improved error handling in both frontend and backend 5. Added proper logging for debugging purposes The solution ensures messages are explicitly fetched from Slack API and stored in the database before analysis is performed.
Ensures channel name is properly displayed in the analysis results page by: 1. Adding proper formatting for the channel name with # prefix 2. Providing fallbacks to analysis.channel_name if resource data is missing 3. Adding a default display as '#channel' if both sources are unavailable 4. Fixing the badge to show 'channel' when type is missing
…el selector - Fixed URL construction in TeamChannelAnalysisHistoryPage to avoid duplicate /api/v1 in path - Added history button to TeamChannelSelector component - Fixed TypeScript errors in integrationService.ts - Removed unused imports and variables - Used integrationService directly for API calls instead of manual fetch
- Add nullable handling to analysis fields to prevent errors with undefined properties - Add proper type casting for API responses - Update ApiError interface to include 'detail' property - Add workspace_id to Integration interface - Add analysis_type to AnalysisOptions interface - Improve type safety in formatText function
- Fixed duplicate datetime import and sorting in integration router - Updated analyzeChannel method in IntegrationContext to use the new analyzeResource method instead - Updated tests to match the new API
- Fix isort errors in integration router.py - Fix missing SlackApiError import - Remove unused datetime import and analysis_date variable - Mock useNavigate hook in TeamChannelSelector tests - Add analyzeResource mock in IntegrationContext tests - Update analyzeChannel to use analyzeResource
Auto-formatting changes from Black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #175
🤖 Generated with Claude Code