Fixed mobile UI for archetype card #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improved mobile responsiveness of the ArchetypeCard component with optimized spacing and layout adjustments for better readability on smaller screens.
- Increased card padding (
p-5) and minimum height (min-h-[260px]) in/components/stats/archetype-card.tsxfor better content spacing on mobile - Enhanced icon visibility by increasing size to
w-14 h-14and adjusting container spacing withgap-5 - Implemented a standalone divider element with
h-px bg-gray-800/50for cleaner separation between sections - Added responsive text sizing with
text-sm sm:text-basefor description andtext-lg sm:text-xlfor title - Optimized power move section positioning with absolute positioning and responsive bottom spacing
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -27,13 +27,13 @@ export default function ArchetypeCard({ archetype }: ArchetypeCardProps) { | |||
| <h2 className="text-gray-400 text-xs uppercase tracking-wider font-medium mb-3"> | |||
| Developer Archetype | |||
| </h2> | |||
| <Card className="bg-gray-900/40 border-gray-800/50 p-4 sm:p-8 overflow-hidden relative min-h-[200px] sm:h-[160px]"> | |||
| <div className="relative flex flex-col sm:flex-row items-start gap-4 sm:gap-6"> | |||
| <Card className="bg-gray-900/40 border-gray-800/50 p-5 sm:p-8 overflow-hidden relative min-h-[260px] sm:h-[170px]"> | |||
There was a problem hiding this comment.
style: Mobile min-height (260px) is larger than desktop height (170px) which may cause inconsistent layouts between breakpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.