refactor(asserts): extract common utilities and improve retry logic #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matt-metivier
commented
Sep 5, 2025
matt-metivier
commented
- Add common utilities for client validation and retry logic
- Refactor alert config and disabled alert config resources to use shared utilities
- Improve retry logic with exponential backoff and jitter
- Remove code duplication across asserts resources
- Update test destroy functions with better retry logic
- Remove stress test skip conditions as retry logic is now more robust
|
|
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
matt-metivier
force-pushed
the
asserts-refactor-common-utilities
branch
from
9668de8 to
e742667
Compare
- Add common utilities for client validation and retry logic - Refactor alert config and disabled alert config resources to use shared utilities - Improve retry logic with exponential backoff and jitter - Remove code duplication across asserts resources - Update test destroy functions with better retry logic - Remove stress test skip conditions as retry logic is now more robust - Update asserts client dependency for compatibility with new API features
matt-metivier
force-pushed
the
asserts-refactor-common-utilities
branch
from
e742667 to
4ea55ad
Compare
- Add CheckStressTestsEnabled function to testutils package - Update stress tests to require TF_ACC_STRESS environment variable - Stress tests will now be skipped unless explicitly enabled - This prevents flaky stress test failures in CI while still allowing developers to run them when needed for testing eventual consistency
arramos84
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.