-
Notifications
You must be signed in to change notification settings - Fork 268
Alerting: Add alert enrichment resource #2332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Add alert enrichment resource #2332
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
6844aae
to
8b9d2c6
Compare
8b9d2c6
to
e214044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side, but we may want someone more familiar with the provider to give it a check over.
// AlertEnrichment creates a new Grafana Alert Enrichment resource. | ||
func AlertEnrichment() NamedResource { | ||
return NewNamedResource[*v1beta1.AlertEnrichment, *v1beta1.AlertEnrichmentList]( | ||
common.CategoryGrafanaApps, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from other app platform resources, but now I'm thinking this should be common.CategoryAlerting
so that it's in the Alerting
section here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated: 5fcdbe8
18cccfb
to
cc87ab8
Compare
cc87ab8
to
fdd3fc4
Compare
…into alexander-akhmetov/alerting-enrichment
Adds new
grafana_apps_alertenrichment_alertenrichment_v1beta1
resource with a single enrichment step for now:assign
.Example