Skip to content

Add Grafana k6 schedules to the provider #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 8, 2025
Merged

Add Grafana k6 schedules to the provider #2273

merged 17 commits into from
Aug 8, 2025

Conversation

DefCon-007
Copy link
Contributor

No description provided.

@DefCon-007 DefCon-007 requested review from a team as code owners July 24, 2025 16:38
@DefCon-007 DefCon-007 requested review from fornfrey and vortegatorres and removed request for a team July 24, 2025 16:38
@github-actions GitHub Actions
Copy link
Contributor

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@DefCon-007 DefCon-007 force-pushed the add-k6-schedules branch 3 times, most recently from 207f696 to 0b8a14b Compare July 25, 2025 11:00
fornfrey
fornfrey requested changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@fornfrey fornfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR! I left a bunch of suggestions.

I'm also not sure if expiring schedules is a good fit for the Terraform model 🤔

@DefCon-007 DefCon-007 force-pushed the add-k6-schedules branch 3 times, most recently from 27d7226 to edfd216 Compare July 29, 2025 13:00
fornfrey
fornfrey requested changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@fornfrey fornfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments! I found 2 more issues after testing locally, but they are easy to fix.

fornfrey
fornfrey approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@fornfrey fornfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! LGTM

@DefCon-007 DefCon-007 merged commit 00c26e7 into main Aug 8, 2025
31 checks passed
@DefCon-007 DefCon-007 deleted the add-k6-schedules branch August 8, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fornfrey fornfrey fornfrey approved these changes

@vortegatorres vortegatorres Awaiting requested review from vortegatorres vortegatorres is a code owner automatically assigned from grafana/k6-cloud-provisioning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DefCon-007 @fornfrey