-
Notifications
You must be signed in to change notification settings - Fork 269
Add grafana_k6_project_allowed_load_zones resource / data source #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
abfb442
to
d1689d8
Compare
Co-authored-by: Oleksandr Kotov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR! I left a couple of suggestions regarding state management. Let me know if you have any questions or need help.
"allowed_load_zones": schema.ListAttribute{ | ||
Description: "List of allowed k6 load zone IDs for this project.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"allowed_load_zones": schema.ListAttribute{ | |
Description: "List of allowed k6 load zone IDs for this project.", | |
"allowed_load_zones": schema.ListAttribute{ | |
Description: "List of allowed k6 private load zones (names) for this project.", |
I've wondered about the naming here: this object is supposed to be only for configuring private LZs, in reality. AFAIK, this is not going to change in the future either.
Changing the allowed_load_zones
to allowed_private_load_zones
seems a bit too verbose ATM, but perhaps, at least the description could contain clarification?
cc @pmdz @fornfrey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tweaked the description a little bit in b239626
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Pawel!
From user's perspective, this can be confusing actually, because it's a name
in Kubernetes resource. But in UI, we call it "ID" 😄 But you're right that this is a frontend level problem: I've brought it up before in the Slack too.
cc @dgzlopes for visibility: just in case, we should change this everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! LGTM
Implement allowed load zones management for k6 projects.
Relevant k6 public API docs: link
grafana_k6_project_allowed_load_zones
resourcegrafana_k6_project_allowed_load_zones
data sourceIssue: https://github.com/grafana/k6-cloud/issues/3512