-
Notifications
You must be signed in to change notification settings - Fork 268
fix: update schema workflow to use comment-based approach for PRs #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Your changes require a provider schema update. Please run the following commands and push the changes: # Update the schema
go run scripts/generate_issue_template.go --update-schema
# Commit the changes
git add provider_schema.json .github/ISSUE_TEMPLATE/3-bug-report-enhanced.yml
git commit -m "chore: update provider schema and issue template"
git push This will update:
This comment was automatically generated by the update-schema workflow. |
Your changes require a provider schema update. Please run the following commands and push the changes: # Update the schema
go run scripts/generate_issue_template.go --update-schema
# Commit the changes
git add provider_schema.json .github/ISSUE_TEMPLATE/3-bug-report-enhanced.yml
git commit -m "chore: update provider schema and issue template"
git push This will update:
This comment was automatically generated by the update-schema workflow. |
🔧 Schema Update RequiredThis PR introduces changes that affect the Terraform provider schema. The issue templates need to be updated. 📋 Required ActionPlease run the generator to update templates: make generate-templates Then commit the updated files:
This comment was generated automatically because schema changes were detected. |
This comment has been minimized.
This comment has been minimized.
Can the CI job also fail if running the command is required, effectively blocking the merge? |
🔧 Schema Update RequiredThis PR introduces changes that affect the Terraform provider schema. The issue templates need to be updated. 📋 Required ActionPlease run the generator to update templates: make generate-templates Then commit the updated files:
This comment was generated automatically because schema changes were detected. |
Successfully does this now. See here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/nit
This PR fixes the
update schema
Github workflow (introduced in #2231) to use a comment-based approach when the schema needs to be updated. Previously the workflow attempted to update the schema and commit it, but due to permission issues, this was failing.See an example of the comment by the
github-actions
bot below.