Skip to content

Conversation

tristanburgess
Copy link
Contributor

fixes https://github.com/grafana/grafana-csp-app/issues/586

This adds default values to relevant field descriptions in CloudProvider resource schemas.

Default values aren't being automatically added to docs by tfplugindocs. This appears to be because we use the newer terraform-plugin-framework, which requires fields with Default values to be Computed, but tfplugindocs won't list Computed fields as having default values (since Computed means the providing service (Cloud Provider API) can provide its own value).

@tristanburgess tristanburgess requested review from a team as code owners June 4, 2025 19:31
@tristanburgess tristanburgess requested a review from HCloward June 4, 2025 19:31
Copy link
Contributor

github-actions bot commented Jun 4, 2025

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Copy link

@HCloward HCloward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @tristanburgess

@tristanburgess tristanburgess merged commit 3ed93a5 into main Jun 4, 2025
30 checks passed
@tristanburgess tristanburgess deleted the tristanburgess/update-cp-docs-with-defaults branch June 4, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants