Skip to content

Alerting: Fix TestAccNotificationPolicy_disableProvenance and TestAccNotificationPolicy_error tests #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Alerting: Fix TestAccNotificationPolicy_disableProvenance and TestAccNotificationPolicy_error tests #2130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac33f3c
Alerting: Fix TestAccNotificationPolicy_disableProvenance test
alexander-akhmetov Apr 10, 2025
c93ca7f
Alerting: Fix TestAccNotificationPolicy_error test
alexander-akhmetov Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 101 additions & 53 deletions internal/resources/grafana/resource_alerting_notification_policy_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,71 +125,119 @@ func TestAccNotificationPolicy_inheritContactPoint(t *testing.T) {
}

func TestAccNotificationPolicy_disableProvenance(t *testing.T) {
testutils.CheckOSSTestsEnabled(t, ">=9.1.0")
t.Run("fetch disable_provenance", func(t *testing.T) {
testutils.CheckOSSTestsEnabled(t, ">=11.3.0")

var policy models.Route
var policy models.Route

resource.Test(t, resource.TestCase{
ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
// Implicitly tests deletion.
CheckDestroy: alertingNotificationPolicyCheckExists.destroyed(&policy, nil),
Steps: []resource.TestStep{
// Create
{
Config: testAccNotificationPolicyDisableProvenance(false),
Check: resource.ComposeTestCheckFunc(
alertingNotificationPolicyCheckExists.exists("grafana_notification_policy.test", &policy),
resource.TestCheckResourceAttr("grafana_notification_policy.test", "disable_provenance", "false"),
),
},
// Import (tests that disable_provenance is fetched from API)
{
ResourceName: "grafana_notification_policy.test",
ImportState: true,
ImportStateVerify: true,
},
// Disable provenance
{
Config: testAccNotificationPolicyDisableProvenance(true),
Check: resource.ComposeTestCheckFunc(
alertingNotificationPolicyCheckExists.exists("grafana_notification_policy.test", &policy),
resource.TestCheckResourceAttr("grafana_notification_policy.test", "disable_provenance", "true"),
),
},
// Import (tests that disable_provenance is fetched from API)
{
ResourceName: "grafana_notification_policy.test",
ImportState: true,
ImportStateVerify: true,
resource.Test(t, resource.TestCase{
ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
// Implicitly tests deletion.
CheckDestroy: alertingNotificationPolicyCheckExists.destroyed(&policy, nil),
Steps: []resource.TestStep{
// Create
{
Config: testAccNotificationPolicyDisableProvenance(false),
Check: resource.ComposeTestCheckFunc(
alertingNotificationPolicyCheckExists.exists("grafana_notification_policy.test", &policy),
resource.TestCheckResourceAttr("grafana_notification_policy.test", "disable_provenance", "false"),
),
},
// Import (tests that disable_provenance is fetched from API)
{
ResourceName: "grafana_notification_policy.test",
ImportState: true,
ImportStateVerify: true,
},
},
// Re-enable provenance
{
Config: testAccNotificationPolicyDisableProvenance(false),
Check: resource.ComposeTestCheckFunc(
alertingNotificationPolicyCheckExists.exists("grafana_notification_policy.test", &policy),
resource.TestCheckResourceAttr("grafana_notification_policy.test", "disable_provenance", "false"),
),
})
})

t.Run("disable_provenance", func(t *testing.T) {
testutils.CheckOSSTestsEnabled(t, ">=9.1.0,<=11.1.0")

var policy models.Route

resource.Test(t, resource.TestCase{
ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
// Implicitly tests deletion.
CheckDestroy: alertingNotificationPolicyCheckExists.destroyed(&policy, nil),
Steps: []resource.TestStep{
// Create
{
Config: testAccNotificationPolicyDisableProvenance(false),
Check: resource.ComposeTestCheckFunc(
alertingNotificationPolicyCheckExists.exists("grafana_notification_policy.test", &policy),
resource.TestCheckResourceAttr("grafana_notification_policy.test", "disable_provenance", "false"),
),
},
// Import (tests that disable_provenance is fetched from API)
{
ResourceName: "grafana_notification_policy.test",
ImportState: true,
ImportStateVerify: true,
},
// Disable provenance
{
Config: testAccNotificationPolicyDisableProvenance(true),
Check: resource.ComposeTestCheckFunc(
alertingNotificationPolicyCheckExists.exists("grafana_notification_policy.test", &policy),
resource.TestCheckResourceAttr("grafana_notification_policy.test", "disable_provenance", "true"),
),
},
// Import (tests that disable_provenance is fetched from API)
{
ResourceName: "grafana_notification_policy.test",
ImportState: true,
ImportStateVerify: true,
},
// Re-enable provenance
{
Config: testAccNotificationPolicyDisableProvenance(false),
Check: resource.ComposeTestCheckFunc(
alertingNotificationPolicyCheckExists.exists("grafana_notification_policy.test", &policy),
resource.TestCheckResourceAttr("grafana_notification_policy.test", "disable_provenance", "false"),
),
},
},
},
})
})
}

func TestAccNotificationPolicy_error(t *testing.T) {
testutils.CheckOSSTestsEnabled(t, ">=9.1.0")
testCases := []struct {
versionConstraint string
errorMessage string
}{
{
versionConstraint: ">=9.1.0,<11.4.0",
errorMessage: "400.+invalid object specification: receiver 'invalid' does not exist",
},
{
versionConstraint: ">=11.4.0",
errorMessage: "400.+Invalid format of the submitted route: receiver 'invalid' does not exist",
},
}

resource.Test(t, resource.TestCase{
ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
Steps: []resource.TestStep{
{
Config: `resource "grafana_notification_policy" "test" {
for _, tc := range testCases {
t.Run(tc.versionConstraint, func(t *testing.T) {
testutils.CheckOSSTestsEnabled(t, tc.versionConstraint)

resource.Test(t, resource.TestCase{
ProtoV5ProviderFactories: testutils.ProtoV5ProviderFactories,
Steps: []resource.TestStep{
{
Config: `resource "grafana_notification_policy" "test" {
group_by = ["..."]
contact_point = "invalid"
}`,
// This tests that the API error message is propagated to the user.
ExpectError: regexp.MustCompile("400.+invalid object specification: receiver 'invalid' does not exist"),
},
},
})
// This tests that the API error message is propagated to the user.
ExpectError: regexp.MustCompile(tc.errorMessage),
},
},
})
})
}
}

func TestAccNotificationPolicy_inOrg(t *testing.T) {
Expand Down
Loading