Skip to content

Conversation

eleijonmarck
Copy link
Contributor

Updating to the openapi-client from - grafana/grafana-openapi-client-go@9cb2bbf

@eleijonmarck eleijonmarck requested review from a team as code owners November 13, 2024 10:19
@eleijonmarck eleijonmarck self-assigned this Nov 13, 2024
Copy link
Contributor

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@IevaVasiljeva
Copy link
Contributor

Thank you so much for helping with the OpenAPI dependency update @spinillos 🏅

@eleijonmarck
Copy link
Contributor Author

@spinillos is a life savor

@@ -0,0 +1,36 @@
package grafana
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be snake_case and I think that if it's only used in tests, then it could live in a _test.go file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups!! Too much java during past week...

@spinillos spinillos enabled auto-merge (squash) November 20, 2024 08:23
@spinillos spinillos merged commit 1243c6f into main Nov 20, 2024
26 checks passed
@spinillos spinillos deleted the eleijonmarck/update-to-latest-openapi-spec branch November 20, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants