Skip to content

improve echo example #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2021
Merged

improve echo example #671

merged 1 commit into from
Apr 24, 2021

Conversation

hellflame
Copy link
Contributor

for better example

  1. output element height resize to 70vh
  2. scroll to bottom on every 'print'

@hellflame
improve echo example
41d4eb0 
1. output element height resize to 70vh
2. scroll to bottom on every 'print'
elithrar
elithrar approved these changes Apr 24, 2021
View reviewed changes
Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this: it seems like a small but worthwhile change.

@elithrar elithrar merged commit e8629af into gorilla:master Apr 24, 2021
influx6 added a commit to ewe-studios/websocket that referenced this pull request May 15, 2021
@influx6
Merge pull request #1 from gorilla/master
f7e7360 
improve echo example (gorilla#671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@elithrar elithrar elithrar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hellflame @elithrar