Clarify how route variables work. (#151) #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this confused the heck out of me while trying to use Gorilla) * Changed `request` to be just `r`, like the other handlers. * Created complete wrapper function instead of just 2 lines.
kisielk
reviewed
Oct 2, 2016
| category := vars["category"] | ||
| func ArticlesCategoryHandler(w http.ResponseWriter, r *http.Request) { | ||
| vars := mux.Vars(r) | ||
| w.Header().Set("Content-Type", "application/json; charset=UTF-8") |
There was a problem hiding this comment.
Why set this to "application/json", or anything at all? It doesn't really contribute anything to the example.
Review comment: setting the header complicates things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this confused the heck out of me while trying to use Gorilla)
requestto be justr, like the other handlers.