Skip to content

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Jun 26, 2024

Fixes #5349

Decided to check for membership to googleapis, since anyone can amend a commit message to say "merge to main"

@sofisl sofisl requested a review from a team as a code owner June 26, 2024 23:54
@sofisl sofisl requested a review from chingor13 June 26, 2024 23:55
@sofisl sofisl changed the title feat: allow other org authors in the PR feat: [auto-approve] allow other authors from googleapis to commit to a PR Jun 26, 2024
@sofisl sofisl added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 26, 2024
@sofisl
Copy link
Contributor Author

sofisl commented Jul 26, 2024

Putting this on hold until I get further approval from ISE team (b/337340434)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: auto approve do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[auto-approve] figure out how to allow commits from certain approved authors when checking author commit status
2 participants