Manifest releaser does not update dependent modules

[dyladan]

Environment details

• OS: macos and linux
• Node.js version: 12, 14, and 16
• npm version: 6 and 7
• release-please version: 11.22.0

Steps to reproduce

1. Create a lerna monorepo with interdependent modules
2. Use manifest releaser to create a release

See an example of a broken PR here: https://github.com/open-telemetry/opentelemetry-js/pull/2444/files

I expected that the packages which were updated like @opentelemetry/core would be reflected in the package.json file of packages which depended on them.

[dyladan]

Is there any recommendation around how to support monorepos with interdependent modules? The manifest releaser doesn't have a lot of available info or docs but the bottom of the documentation md file seems to imply that the node-workspace plugin should work for that. Do I need to do anything other than add the plugin to the config to enable it?

[bcoe]

@dyladan you should be able to simply add the plugin, like this:

https://github.com/looker-open-source/sdk-codegen/blob/main/release-please-config.json#L2

See: https://github.com/googleapis/release-please/blob/master/docs/manifest-releaser.md#plugins

Let me know if it does the trick for you?

[dyladan]

No that is not working for me. Here's the config:

https://github.com/open-telemetry/opentelemetry-js/blob/main/release-please-config.json#L3

And the PR does not update the dependencies of dependent modules.

[remarkablemark]

I am also experiencing release PR not updating dependent packages of Lerna monorepo

See little-spoon-dev/design-system#12

This is my release-please-config.json

[bcoe]

@remarkablemark was the version that was not updated a major bump? there was an issue related to this fixed last week.

[remarkablemark]

@remarkablemark was the version that was not updated a major bump? there was an issue related to this fixed last week.

@bcoe it wasn't a major bump but thanks for checking in

[phated]

@remarkablemark it looks like it wasn't a major bump, but you don't use semver versioning, so lerna would have had nothing to bump. The change that @bcoe mentioned forces linking across all local projects, so it should solve your issue.

[remarkablemark]

@phated how do I use semver versioning? In my project, I'm using Lerna independent versioning + Conventional Commits

I also created a separate repo that has the same behavior as the other project: https://github.com/remarkablemark/release-please-manifest-demo

[phated]

@remarkablemark A quick scan of your demo repo seems to indicate the problem is that you don't actually have a root package.json that defines your workspaces. This would mean that RP wouldn't be able to link together your monorepo dependencies.

[remarkablemark]

@phated you are right, that was a bad example. The other project did have a root package.json since it uses Lerna + Yarn workspaces. However, I have removed Release Please from the project.

[bcoe]

@dyladan I'm getting a 404 with the config you shared, are you still blocked?