Skip to content

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 9, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 9, 2021
@suztomo
Copy link
Member Author

suztomo commented Feb 9, 2021

Hmm. The file seems auto-generated. I guess I shouldn't touch this.

This pull request is touching the following templated files:
.github/workflows/ci.yaml

@suztomo
Copy link
Member Author

suztomo commented Feb 9, 2021

The lint passed.

Screen Shot 2021-02-09 at 11 53 00

@suztomo suztomo closed this Feb 9, 2021
new GoogleIdTokenVerifier.Builder(
new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(),
new GsonFactory())
new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(), new GsonFactory())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn com.coveo:fmt-maven-plugin:format changed this line.

Comment on lines -73 to +72
new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(),
new GsonFactory())
new GooglePublicKeysManagerTest.PublicCertsMockHttpTransport(), new GsonFactory())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn com.coveo:fmt-maven-plugin:format changed this line.

Comment on lines -104 to 105
GooglePublicKeysManager certs =
new GooglePublicKeysManager.Builder(
new PublicCertsMockHttpTransport(), new GsonFactory())
new GooglePublicKeysManager.Builder(new PublicCertsMockHttpTransport(), new GsonFactory())
.build();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn com.coveo:fmt-maven-plugin:format changed this line.

import com.google.api.client.googleapis.testing.services.MockGoogleClient;
import com.google.api.client.googleapis.testing.services.MockGoogleClientRequest;
import com.google.api.client.http.ByteArrayContent;
import com.google.api.client.http.ExponentialBackOffPolicy;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mvn com.coveo:fmt-maven-plugin:format changed this line.

@suztomo suztomo reopened this Feb 9, 2021
@suztomo suztomo closed this Feb 9, 2021
gcf-owl-bot bot added a commit that referenced this pull request Nov 7, 2022
* chore(java): update gcp-releasetool and cryptography in java requirements file
Source-Link: googleapis/synthtool@74d0956
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 8, 2022
…2178)

* chore(java): update gcp-releasetool and cryptography in java requirements file
Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
blakeli0 pushed a commit that referenced this pull request Dec 16, 2022
…2178)

* chore(java): update gcp-releasetool and cryptography in java requirements file
Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
blakeli0 pushed a commit that referenced this pull request Dec 16, 2022
…2178)

* chore(java): update gcp-releasetool and cryptography in java requirements file
Source-Link: https://togithub.com/googleapis/synthtool/commit/74d0956884c1bb9dc901b52de35ca2bca025a74e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:142286d973c7b6d58186070f203b50058a20a7d7b42147996db24921a18da1b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant