Skip to content

exclude tuple-like types from OnceAction forwarding constructors #4818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

exclude tuple-like types from OnceAction forwarding constructors #4818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions googlemock/include/gmock/gmock-actions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,16 @@ struct disjunction<P1, Ps...>
template <typename...>
using void_t = void;

template <template <class...> class Template, class T>
struct is_specialization_of : std::false_type {};

template <template <class...> class Template, class... Ts>
struct is_specialization_of<Template, Template<Ts...>> : std::true_type {};

template <typename T>
using is_tuple_like = is_specialization_of<std::tuple,
typename std::decay<T>::type>;

// Detects whether an expression of type `From` can be implicitly converted to
// `To` according to [conv]. In C++17, [conv]/3 defines this as follows:
//
Expand Down Expand Up @@ -456,6 +466,8 @@ class OnceAction<Result(Args...)> final {
// traits above.
internal::negation<std::is_same<
OnceAction, typename std::decay<Callable>::type>>,
// Never treat tuple wrappers as callables.
internal::negation<internal::is_tuple_like<Callable>>,
IsDirectlyCompatible<Callable>> //
::value,
int>::type = 0>
Expand All @@ -473,6 +485,8 @@ class OnceAction<Result(Args...)> final {
// traits above.
internal::negation<std::is_same<
OnceAction, typename std::decay<Callable>::type>>,
// Never treat tuple wrappers as callables.
internal::negation<internal::is_tuple_like<Callable>>,
// Exclude callables for which the overload above works.
// We'd rather provide the arguments if possible.
internal::negation<IsDirectlyCompatible<Callable>>,
Expand Down