Skip to content

bugfix of runtime error in the filesCreatePdf function in samples #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

bugfix of runtime error in the filesCreatePdf function in samples #418

merged 2 commits into from
Mar 24, 2025

Conversation

julurisaichandu
Copy link
Contributor

@julurisaichandu julurisaichandu commented Mar 12, 2025 •
edited
Loading

fix #416

  • Fixes the runtime error when running the samples/files.js file because of incorrect variable handling
  • Fixed camel case issue for CreatePDF function causing errors in check_samples.js and insert-import-comments.js.

@Annhiluc Annhiluc self-requested a review March 24, 2025 23:18
Annhiluc
Annhiluc approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@Annhiluc Annhiluc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here!

@Annhiluc Annhiluc merged commit 013bce9 into google-gemini:main Mar 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Annhiluc Annhiluc Annhiluc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix runtime error for the samples/files.js filesCreatePdf method
2 participants
@julurisaichandu @Annhiluc