-
Notifications
You must be signed in to change notification settings - Fork 307
Description
Description of the bug:
Hello team,
While inspecting the module contents of the @google/genai package (version 1.12.0), I noticed a few
errors in the enharmonic naming of the relative minor keys in the Scale constants.
This appears to be for an experimental or undocumented music generation feature, but the music
theory is incorrect and could cause issues for anyone using these constants.
Here are the identified errors and their corrections:
│ Incorrect Constant │ Correct Name │ Reason │
│ E_MAJOR_D_FLAT_MINOR │ E_MAJOR_C_SHARP_MINOR │ The relative minor of E Major is C# minor. │
│ B_MAJOR_A_FLAT_MINOR │ B_MAJOR_G_SHARP_MINOR │ The relative minor of B Major is G# minor. │
│ A_MAJOR_G_FLAT_MINOR │ A_MAJOR_F_SHARP_MINOR │ The relative minor of A Major is F# minor. │
This feedback is provided to help improve the accuracy of the library. Thank you for your work on
this project.
Actual vs expected behavior:
Actual Beheavior: The scale names use incorrect enharmonics (e.g., E_MAJOR_D_FLAT_MINOR instead of E_MAJOR_C_SHARP_MINOR)
Expected Beheavior: The scale names should use the correct enharmonic equivalents for relative minors.
Any other information you'd like to share?
No response