Use correct pager logic for files.list

[markmcd]

The existing syntax worked but is very clunky, and not idiomatic.

There's an example in cache.list too but the tests there are failing.

[gemini-code-assist]

Summary of Changes

Hello @markmcd, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the file listing mechanism to leverage a more idiomatic and cleaner approach for handling paginated results from an API. The update streamlines the code responsible for fetching and processing file lists, making it more aligned with current JavaScript best practices.

Highlights

• Refactored File Listing Logic: The files.list function in javascript/files.js has been updated to use the for await...of syntax for iterating over paginated API responses. This replaces the previous while (true) loop with explicit hasNextPage() and nextPage() calls.
• Improved Readability and Idiomatic Usage: The change makes the code more concise and aligns with modern JavaScript patterns for handling asynchronous iterators, improving readability and maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request significantly improves the code for listing files by replacing a manual, clunky pagination implementation with a modern and idiomatic for await...of loop. This change makes the code much cleaner, more readable, and easier to maintain. This is an excellent simplification. I have one minor stylistic suggestion to ensure code consistency.