Skip to content

Conversation

boyazeno
Copy link

Motivation

composite object has parameter quat. But it is not actually used anywhere when create the objects. On the contrary, offset parameter are used as real off set to all sub objects. So with a reasonable guess, the quat should be also used to rotate each sub objects.

How to reproduce

Simply create a composite and assign a nontrivial quat, you will see no rotation is applied.

Fix

In this patch, an extra rotation is applied to each sub objects. Tests are added for simple checking.

Copy link

google-cla bot commented Jul 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@boyazeno boyazeno changed the title Composite quat bug fix path Composite quat bug fix Jul 17, 2025
@boyazeno boyazeno changed the title Composite quat bug fix Fix quat not used inside composite Jul 19, 2025
@yuvaltassa yuvaltassa requested a review from quagla July 21, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant