Fix quat not used inside composite #2753
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
composite
object has parameterquat
. But it is not actually used anywhere when create the objects. On the contrary,offset
parameter are used as real off set to all sub objects. So with a reasonable guess, thequat
should be also used to rotate each sub objects.How to reproduce
Simply create a composite and assign a nontrivial
quat
, you will see no rotation is applied.Fix
In this patch, an extra rotation is applied to each sub objects. Tests are added for simple checking.