Skip to content

Fix webrtc example that relied on JSON integers #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix webrtc example that relied on JSON integers #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions networking/webrtc_signaling/client/ws_webrtc_client.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func send_answer(id: int, answer: String) -> Error:

func _send_msg(type: int, id: int, data: String = "") -> Error:
return ws.send_text(JSON.stringify({
"type": type,
"id": id,
"type": str(type),
"id": str(id),
"data": data,
}))
2 changes: 1 addition & 1 deletion networking/webrtc_signaling/project.godot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The protocol is text based, and composed by a command and possibly
multiple payload arguments, each separated by a new line."
config/tags=PackedStringArray("demo", "network", "official")
run/main_scene="res://demo/main.tscn"
config/features=PackedStringArray("4.2")
config/features=PackedStringArray("4.3")

[debug]

Expand Down
4 changes: 2 additions & 2 deletions networking/webrtc_signaling/server/ws_webrtc_server.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ class Peer extends RefCounted:

func send(type: int, id: int, data: String = "") -> void:
return ws.send_text(JSON.stringify({
"type": type,
"id": id,
"type": str(type),
"id": str(id),
"data": data,
}))

Expand Down