Skip to content

Fix jira api #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix jira api #510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .jira.d/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
config:
stop: true
password-source: pass
password-source: keyring
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer but changing this config file does not seem to be in the scope of this PR.

Suggested change
password-source: keyring
password-source: pass

endpoint: https://go-jira.atlassian.net
user: admin
login: [email protected]
Expand Down
4 changes: 2 additions & 2 deletions search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (o *SearchOptions) ProvideSearchRequest() *jiradata.SearchRequest {
return req
}

// https://docs.atlassian.com/jira/REST/cloud/#api/2/search-searchUsingSearchRequest
// https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-issue-search/#api-rest-api-3-search-jql-post
func (j *Jira) Search(sp SearchProvider, opts ...SearchOpt) (*jiradata.SearchResults, error) {
return Search(j.UA, j.Endpoint, sp, opts...)
}
Expand Down Expand Up @@ -108,7 +108,7 @@ func Search(ua HttpClient, endpoint string, sp SearchProvider, opts ...SearchOpt
if err != nil {
return nil, err
}
uri := URLJoin(endpoint, "rest/api/2/search")
uri := URLJoin(endpoint, "rest/api/3/search/jql")
resp, err := ua.Post(uri, "application/json", bytes.NewBuffer(encoded))
if err != nil {
return nil, err
Expand Down