Skip to content

Move git command to git/gitcmd #35483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 16, 2025
Merged

Move git command to git/gitcmd #35483

merged 8 commits into from
Sep 16, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 14, 2025

The name cmd is already used in many places and may cause conflicts, so I chose gitcmd instead to minimize potential naming conflicts.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 14, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/migrations labels Sep 14, 2025
hiifong
hiifong reviewed Sep 15, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 15, 2025
@wxiaoguang
Copy link
Contributor

I believe using gitcmd.New(...) is sufficiently concise and clear.

No, don't use single word, it's very difficult to maintain.

@hiifong
Copy link
Member

hiifong commented Sep 15, 2025

I believe using gitcmd.New(...) is sufficiently concise and clear.

No, don't use single word, it's very difficult to maintain.

Then I'd like to hear your thoughts.

@wxiaoguang
Copy link
Contributor

I believe using gitcmd.New(...) is sufficiently concise and clear.

No, don't use single word, it's very difficult to maintain.

Then I'd like to hear your thoughts.

Two-word names are more maintainable

@lunny
Copy link
Member Author

lunny commented Sep 15, 2025

I believe using gitcmd.New(...) is sufficiently concise and clear.

No, don't use single word, it's very difficult to maintain.

Then I'd like to hear your thoughts.

Two-word names are more maintainable

reverted

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 16, 2025
@lunny lunny added this to the 1.25.0 milestone Sep 16, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 16, 2025
@lunny lunny merged commit 9332ff2 into go-gitea:main Sep 16, 2025
26 checks passed
@lunny lunny deleted the lunny/move_git_command branch September 16, 2025 06:33
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 16, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 18, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
436f93d 
* giteaofficial/main:
  Clean up npm dependencies (go-gitea#35508)
  Correctly override user unitmodes (go-gitea#35501)
  [skip ci] Updated translations via Crowdin
  Enable more markdown paste features in textarea editor (go-gitea#35494)
  Move git command to git/gitcmd (go-gitea#35483)
  Exposing TimeEstimate field  in the API (go-gitea#35475)
  Clean up npm dependencies (go-gitea#35484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code modifies/migrations type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @wxiaoguang @hiifong @silverwind @GiteaBot