Improve create pull request head ref #35469
Open
+204
−240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
lunny
commented
Sep 12, 2025
| @@ -214,35 +214,30 @@ func ProcReceive(ctx context.Context, repo *repo_model.Repository, gitRepo *git. | |||
| } | |||
| } | |||
|
|
|||
| // Store old commit ID for review staleness checking | |||
| oldHeadCommitID := pr.HeadCommitID | |||
There was a problem hiding this comment.
line 190 have checked whether the old head commit id is the same as the new one.
github-actions
bot
added
the
modifies/api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git fetchinstead ofgit pushto update the pull request head reference.HeadCommitIDfrom the pull request struct to ensure the head commit ID is always read directly when needed, improving clarity.GetDivergingCommitsto run after the head commit reference is created, so it no longer depends on the temporary repository. This also prepares for future refactors where temporary repository creation may be avoided.