Skip to content

Conversation

timofurrer
Copy link
Member

Refs: #771

@armsnyder do you know anything about that force flag? And how it's supposed to work?
The test currently is failing (it was never executed, so we didn't notice) and it's apparent why, but I don't see what the intention was and how to make it "work" again :D

@github-actions github-actions bot added size/M and removed size/S labels Feb 15, 2022
@timofurrer timofurrer self-assigned this Feb 15, 2022
Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(We discussed in DMs) The failing test was not correctly testing the force attribute, so we're deleting it.

@armsnyder armsnyder added this to the v3.10.0 milestone Feb 15, 2022
@armsnyder armsnyder changed the title Bugfix in LDAP Group Link resource and re-enable tests Fix gitlab_group_ldap_link panic on group_access attribute and re-enable tests Feb 15, 2022
@timofurrer timofurrer merged commit b33ea26 into gitlabhq:main Feb 15, 2022
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider resource Adds or modifies a resource size/M tests
Development

Successfully merging this pull request may close these issues.

2 participants