-
Notifications
You must be signed in to change notification settings - Fork 318
Add topic resource support, third trial #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add topic resource support, third trial #871
Conversation
Thanks @eliobischof for creating yet another PR for this! 🎉 I'm still super unhappy about the tradeoffs we had to make here (absolutely not your fault @eliobischof :D )- but for the lack of a better solution I think we can merge this. I think I'll follow up with some changes in go-gitlab (xanzy/go-gitlab#1381) to support removing the avatar (since https://docs.gitlab.com/ee/api/topics.html#remove-a-topic-avatar) is available and also include the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some typos and style things.
Co-authored-by: Adam Snyder <[email protected]>
Co-authored-by: Adam Snyder <[email protected]>
I took the liberty and applied @armsnyder suggestions. Once the checks pass I'll merge! Thanks @eliobischof for your effort ❤️ much appreciated 🎉 |
I've applied your suggestions 🎉
This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you! |
Description
Cherry picked the commits from #832 that has a messed up commit history.
PR Checklist
//lintignore
comments that came from copied code. Linter rules are meant to be enforced on new code.