Skip to content

Conversation

eliobischof
Copy link
Contributor

Description

Cherry picked the commits from #832 that has a messed up commit history.

PR Checklist

  • Resource attributes match 1:1 the names and structure of the API resource in the GitLab API documentation.
  • Examples are updated with:
    • A *.tf file for the resource/s with at least one usage example
    • A *.sh file for the resource/s with an import example (if applicable)
  • New resources have at minimum a basic test with three steps:
    • Create the resource
    • Update the attributes
    • Import the resource
  • No new //lintignore comments that came from copied code. Linter rules are meant to be enforced on new code.

@timofurrer
Copy link
Member

timofurrer commented Feb 14, 2022

Thanks @eliobischof for creating yet another PR for this! 🎉

I'm still super unhappy about the tradeoffs we had to make here (absolutely not your fault @eliobischof :D )- but for the lack of a better solution I think we can merge this.

I think I'll follow up with some changes in go-gitlab (xanzy/go-gitlab#1381) to support removing the avatar (since https://docs.gitlab.com/ee/api/topics.html#remove-a-topic-avatar) is available and also include the total_projects_count and avatar_url as Computed attributes. But it shouldn't block that PR from finally going through :)

Copy link
Collaborator

@armsnyder armsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some typos and style things.

@timofurrer
Copy link
Member

I took the liberty and applied @armsnyder suggestions. Once the checks pass I'll merge!

Thanks @eliobischof for your effort ❤️ much appreciated 🎉

@timofurrer timofurrer dismissed armsnyder’s stale review February 15, 2022 06:50

I've applied your suggestions 🎉

@timofurrer timofurrer merged commit a1071cc into gitlabhq:main Feb 15, 2022
@armsnyder armsnyder added this to the v3.10.0 milestone Feb 15, 2022
@eliobischof eliobischof deleted the feature/topics-clean-again branch February 15, 2022 08:43
@github-actions
Copy link

This functionality has been released in v3.10.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants