Skip to content

Conversation

timofurrer
Copy link
Member

This change set adds support for the newly introduced title field in GitLab 15.0 of the Topics API.

To support previous GitLab instances the title resource attribute is optional even though in the API it's required.

However, it's an error if the user sets the title for GitLab releases prior to 15.0 and if the user doesn't set it for GitLab releases from 15.0 on ...

Once we integrate 15.0 we have to adjust the tests, too to properly support the resource.

It's currently blocked by a new go-gitlab release we require.

Closes: #1043

@timofurrer timofurrer added blocked We are currently blocked to implement this go-gitlab Is related to go-gitlab. Maybe be combined with other labels, like `blocked`. labels Apr 30, 2022
@timofurrer timofurrer requested a review from armsnyder April 30, 2022 18:29
@timofurrer timofurrer self-assigned this Apr 30, 2022
@timofurrer timofurrer added the needs-rebase For PRs which need a rebase label Apr 30, 2022
@nejch
Copy link

nejch commented May 11, 2022

@timofurrer https://github.com/xanzy/go-gitlab/releases/tag/v0.65.0 is out so when you get the version bump in this repo this should be good to go 🥳

@timofurrer timofurrer added this to the v3.15.0 milestone May 22, 2022
@timofurrer timofurrer force-pushed the feature/topic-title branch from 8900531 to 99b14f5 Compare May 22, 2022 13:37
@timofurrer timofurrer force-pushed the feature/topic-title branch from 99b14f5 to 9bce383 Compare May 22, 2022 14:06
@timofurrer timofurrer requested a review from RicePatrick May 22, 2022 17:23
@timofurrer
Copy link
Member Author

blocked by: #1095

@timofurrer
Copy link
Member Author

Closing in favor of: #1095

@timofurrer timofurrer closed this May 22, 2022
@github-actions github-actions bot removed the needs-rebase For PRs which need a rebase label May 22, 2022
@timofurrer timofurrer mentioned this pull request May 23, 2022
@github-actions
Copy link

This functionality has been released in v3.15.0 of the Terraform GitLab Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue. Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked We are currently blocked to implement this documentation go-gitlab Is related to go-gitlab. Maybe be combined with other labels, like `blocked`. provider resource Adds or modifies a resource size/M tests
Development

Successfully merging this pull request may close these issues.

2 participants