fix: ignore merge commits for file diffs #859
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've observed the following recurring exception in handling `check_run` events. The stack trace indicates we're trying to read from `action` when it isn't defined. |
This accepts potentially partial check messages instead of crashing the event processing.
```
TypeError: Cannot read properties of undefined (reading 'additions')
~~~~~ redacted ~~~~~
at Array.reduce (<anonymous>)
at _Settings.handleResults ( ~~~~~ redacted ~~~~~)
```
Move from comparing the branch base against target to `pulls.listFiles`. This solves for a bug where updating a given command with changes from the target branch triggered the settings change detection.
|
@decyjphr could you have a look at this bug fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from comparing the branch base against target to
pulls.listFiles.This solves for a bug where updating a given command with changes from
the target branch triggered the settings change detection.
Stacks on top of #858