Skip to content

Java: Make a TC overlay caller. #20459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Java: Make a TC overlay caller. #20459

merged 1 commit into from
Sep 19, 2025
+1 −0

Conversation

alexet
Copy link
Contributor

@alexet alexet commented Sep 17, 2025 •
edited
Loading

This avoids materialising it in overlay mode.

@github-actions github-actions bot added the Java label Sep 17, 2025
@alexet alexet added the no-change-note-required This PR does not need a change note label Sep 18, 2025
@alexet alexet requested a review from kaspersv September 18, 2025 15:21
@alexet alexet marked this pull request as ready for review September 18, 2025 15:21
@alexet alexet requested a review from a team as a code owner September 18, 2025 15:21
@Copilot Copilot AI review requested due to automatic review settings September 18, 2025 15:21
Copilot
Copilot AI reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an overlay[caller?] annotation to optimize the transitive closure computation in Java dataflow analysis by preventing materialization in overlay mode.

  • Adds overlay[caller?] annotation to the localFlowStepPlus predicate

@kaspersv
Copy link
Contributor

The DCA experiment shows unique alert query locations for source iSoron__uhabits@897a236__323e. It looks like irrelevant dependency wobble. Have you confirmed with the Java team that we can ignore it?

@kaspersv kaspersv mentioned this pull request Sep 19, 2025
Merged
@alexet
Copy link
Contributor Author

alexet commented Sep 19, 2025

A similar change exists on a nightly from a couple of days ago as well, and it looks like an alert in a generated file anyway.

@alexet alexet merged commit 27e2c4d into main Sep 19, 2025
19 checks passed
@alexet alexet deleted the alexet/caller_tc branch September 19, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@kaspersv kaspersv kaspersv approved these changes

Assignees

@kaspersv kaspersv

Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexet @kaspersv