-
Notifications
You must be signed in to change notification settings - Fork 385
Merge main into releases/v3 #3081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update dependencies
Mergeback v3.30.0 refs/heads/releases/v3 into main
Bumps the actions group with 1 update: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.256.0 to 1.257.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@efbf473...4451173) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.257.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the npm group with 1 update: [@types/get-folder-size](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/get-folder-size). Updates `@types/get-folder-size` from 2.0.0 to 3.0.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/get-folder-size) --- updated-dependencies: - dependency-name: "@types/get-folder-size" dependency-version: 3.0.4 dependency-type: direct:development update-type: version-update:semver-major dependency-group: npm ... Signed-off-by: dependabot[bot] <[email protected]>
…rn/npm-8a1409518d
…s-d07bd62061 Bump ruby/setup-ruby from 1.256.0 to 1.257.0 in the actions group
…09518d Bump @types/get-folder-size from 2.0.0 to 3.0.4 in the npm group
Co-authored-by: Esben Sparre Andreasen <[email protected]>
Fix missing/wrong properties in `createTestConfig`
Hard-code quality queries
Co-authored-by: henrymercer <[email protected]>
Fix update-bundle workflow
…further modification
…ties Overlay databases: Use `Config` instead of `AugmentationProperties`
Remove `augmentationProperties` from `Config` type
Update default bundle to 2.23.0
Accept `git_source` registry configurations for Go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This release merges multiple pull requests into the releases/v3 branch, including package dependency updates, refactoring of configuration handling, and CodeQL bundle version updates.
- Updates default CodeQL bundle version to 2.23.0
- Refactors configuration management by moving properties from
augmentationProperties
to main config - Updates dependencies including
del
to v8.0.0 andget-folder-size
to v5.0.0
Reviewed Changes
Copilot reviewed 27 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/util.ts | Updates del import and getFolderSize usage for new package versions |
src/upload-lib.ts | Replaces file-url dependency with native Node.js url module |
src/testing-utils.ts | Updates test configuration structure for refactored config |
src/status-report.ts | Adds new status report creation functions and moves from init-action |
src/start-proxy.ts | Extends Go language support to include git_source registry type |
src/overlay-database-utils.ts | Updates to use config properties directly instead of augmentationProperties |
src/init-action.ts | Refactors to use extracted status report creation function |
src/defaults.json | Updates CodeQL CLI version to 2.23.0 |
src/debug-artifacts.ts | Updates del import for new package version |
src/config-utils.ts | Major refactoring of configuration structure and function names |
src/codeql.ts | Updates to use new config structure and query handling |
src/analyze.ts | Updates del import and code quality query handling |
src/analyses.ts | Adds code quality queries constant |
package.json | Updates version and dependencies including del and get-folder-size |
Comments suppressed due to low confidence (1)
src/util.ts:1
- The comment refers to
codeDir
but the parameter is namedcacheDir
. This creates confusion about what directory is being processed.
import * as fs from "fs";
const LANGUAGE_TO_REGISTRY_TYPE: Partial<Record<KnownLanguage, string[]>> = { | ||
java: ["maven_repository"], | ||
csharp: ["nuget_feed"], | ||
javascript: ["npm_registry"], | ||
python: ["python_index"], | ||
ruby: ["rubygems_server"], | ||
rust: ["cargo_registry"], | ||
go: ["goproxy_server", "git_source"], | ||
} as const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The as const
assertion is incorrect here since the object values are arrays, not readonly tuples. This should either use as const
with readonly arrays or remove the assertion entirely.
const LANGUAGE_TO_REGISTRY_TYPE: Partial<Record<KnownLanguage, string[]>> = { | |
java: ["maven_repository"], | |
csharp: ["nuget_feed"], | |
javascript: ["npm_registry"], | |
python: ["python_index"], | |
ruby: ["rubygems_server"], | |
rust: ["cargo_registry"], | |
go: ["goproxy_server", "git_source"], | |
} as const; | |
}; |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Merging 2d2f57e into
releases/v3
.Conductor for this PR is @aibaars.
Contains the following pull requests:
createTestConfig
#3071 (@mbg)Config
instead ofAugmentationProperties
#3072 (@mbg)augmentationProperties
fromConfig
type #3075 (@mbg)git_source
registry configurations for Go #3079 (@mbg)Please do the following:
releases/v3
branch.Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.