fix: Unwrap joinErr in gin.Error() #4260
Open
+50
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I am ready for a PR review. |
arshukla98
force-pushed
the
Issue_4237
branch
2 times, most recently
from
e17500e to
0790c13
Compare
|
Hi, I am ready for a PR review. |
|
Hi @appleboy , I would like to make a request to trigger the github action workflow. |
1 similar comment
|
Hi @appleboy , I would like to make a request to trigger the github action workflow. |
FarmerChillax
suggested changes
Jun 30, 2025
Comment on lines
+187
to
+195
| if multi, ok := err.(interface{ Unwrap() []error }); ok { | ||
| for _, e := range multi.Unwrap() { | ||
| result = append(result, unwrapJoinErr(e)...) | ||
| } | ||
| } else if single := errors.Unwrap(err); single != nil { | ||
| result = append(result, unwrapJoinErr(single)...) | ||
| } else { | ||
| result = append(result, err) | ||
| } |
There was a problem hiding this comment.
It is better to use switch syntax or a single if statement instead of ifelse.
Comment on lines
+183
to
+185
| if err == nil { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This is prone to panic. Maybe returning an empty slice would be better
Comment on lines
+170
to
178
| for _, msg := range a { | ||
| for _, err := range unwrapJoinErr(msg.Err) { | ||
| fmt.Fprintf(&buffer, "Error #%02d: %s\n", count, err) | ||
| if msg.Meta != nil { | ||
| fmt.Fprintf(&buffer, " Meta: %v\n", msg.Meta) | ||
| } | ||
| count++ | ||
| } | ||
| } |
There was a problem hiding this comment.
The nesting of loops here seems unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference
Closes: #4237
masterTest Report
20250607_gin_tests_0790c13.pdf
Page 22 ->