Skip to content

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Feb 27, 2025

Add specific deletion implementation/service for replicated API tokens in region silos.

@mdtro mdtro requested a review from a team as a code owner February 27, 2025 21:49
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/hybridcloud/services/replica/impl.py 25.00% 3 Missing ⚠️
src/sentry/hybridcloud/services/replica/service.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #86069      +/-   ##
==========================================
- Coverage   87.89%   87.88%   -0.01%     
==========================================
  Files        9705     9705              
  Lines      550275   550301      +26     
  Branches    21419    21419              
==========================================
+ Hits       483657   483658       +1     
- Misses      66237    66262      +25     
  Partials      381      381              

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mdtro mdtro merged commit 1a80654 into master Feb 28, 2025
50 checks passed
@mdtro mdtro deleted the mdtro/api-token-replica-delete branch February 28, 2025 17:04
mdtro added a commit that referenced this pull request Mar 7, 2025
)

Continuation of #86069.
Use the newly created services in the model to process deletions.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants