fix(oauth): add locking to prevent race conditions in grant exchange #85570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #85570 +/- ##
===========================================
+ Coverage 33.00% 87.78% +54.78%
===========================================
Files 8694 10263 +1569
Lines 483957 580499 +96542
Branches 22645 22645
===========================================
+ Hits 159725 509616 +349891
+ Misses 323797 70448 -253349
Partials 435 435 |
…xchanges - Add InvalidGrantError and ExpiredGrantError - Add get_lock_key method to ApiGrant - Add locking around grant exchanges in ApiToken.from_grant - Add tests for race conditions
- add application status check in grant validation - better error handling for lock acquisition failures - add tests for concurrent grant usage
mdtro
force-pushed
the
mdtro/api-grant-security
branch
from
d2c982f to
51e64ce
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled from #82052 to break out these changes into smaller PRs.
Use locks to ensure an
ApiGrantcannot be used twice during a race condition that would result in multiple access/refresh token pairs.