Skip to content

Relax version reqs on opentelemetry deps #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 12, 2025
Merged

Relax version reqs on opentelemetry deps #931

merged 6 commits into from
Aug 12, 2025

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Aug 1, 2025

This enables installing sentry in apps with old
opentelemetry libs, that are not compatible with
tracing, in which case tracing is simply not
loaded and cannot be used as a feature.

Closes #928

@solnic solnic linked an issue Aug 1, 2025 that may be closed by this pull request
Cannot upgrade to Sentry 11.0 (w/o tracing) because of OTel dependencies #928
Closed
@solnic solnic force-pushed the 928-cannot-upgrade-to-sentry-110-wo-tracing-because-of-otel-dependencies branch 6 times, most recently from c48c07f to 409fcae Compare August 1, 2025 11:40
@solnic solnic force-pushed the 928-cannot-upgrade-to-sentry-110-wo-tracing-because-of-otel-dependencies branch from 0bf8334 to aca525b Compare August 1, 2025 11:56
solnic added 4 commits August 1, 2025 11:57
@solnic
Relax version reqs on opentelemetry deps
71e47db 
This enables installing sentry in apps with old
opentelemetry libs, that are not compatible with
tracing, in which case tracing is simply not
loaded and cannot be used as a feature.

Closes #928
@solnic
Explain why we allow >= 0.0.0 for otel libs
1b4bbba
@solnic
Add jason for older elixirs
222c36e
@solnic
Update CHANGELOG
e8fde4f
@solnic solnic force-pushed the 928-cannot-upgrade-to-sentry-110-wo-tracing-because-of-otel-dependencies branch from aca525b to e8fde4f Compare August 1, 2025 11:57
@solnic solnic marked this pull request as ready for review August 1, 2025 11:58
@solnic solnic mentioned this pull request Aug 1, 2025
Closed
sl0thentr0py
sl0thentr0py reviewed Aug 1, 2025
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. can we add a logger warning in init if traces_sample_rate is set and the dependencies are not satisfied?

@solnic solnic requested a review from sl0thentr0py August 1, 2025 14:53
sl0thentr0py
sl0thentr0py approved these changes Aug 1, 2025
View reviewed changes
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! :shipit:

@solnic solnic merged commit 913ecff into master Aug 12, 2025
11 of 12 checks passed
@solnic solnic deleted the 928-cannot-upgrade-to-sentry-110-wo-tracing-because-of-otel-dependencies branch August 12, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

@whatyouhide whatyouhide Awaiting requested review from whatyouhide

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot upgrade to Sentry 11.0 (w/o tracing) because of OTel dependencies
2 participants
@solnic @sl0thentr0py