Fix regexes on Erlang/OTP 28 #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
solnic
added a commit
that referenced
this pull request
May 28, 2025
* Tweak credit card regex handling for OTP-28 Just like in #889 * Update CHANGELOG
|
Thanks @josevalim for the fix! It still not possible to set this option now on Docs still point user to set this to a list of 
|
|
We are planning to fix it on Erlang/OTP 28.1. |
firestack
added a commit
to mbta/prediction_analyzer
that referenced
this pull request
Jul 24, 2025
this fails to compile on OTP 28 (getsentry/sentry-elixir#889) But this also relies on Phoenix 1.6. so we need to update that first
firestack
added a commit
to mbta/prediction_analyzer
that referenced
this pull request
Jul 25, 2025
this fails to compile on OTP 28 (getsentry/sentry-elixir#889) But this also relies on Phoenix 1.6. so we need to update that first
firestack
added a commit
to mbta/prediction_analyzer
that referenced
this pull request
Jul 25, 2025
this fails to compile on OTP 28 (getsentry/sentry-elixir#889) But this also relies on Phoenix 1.6. so we need to update that first
firestack
added a commit
to mbta/prediction_analyzer
that referenced
this pull request
Jul 25, 2025
this fails to compile on OTP 28 (getsentry/sentry-elixir#889) But this also relies on Phoenix 1.6. so we need to update that first
firestack
added a commit
to mbta/prediction_analyzer
that referenced
this pull request
Aug 13, 2025
this fails to compile on OTP 28 (getsentry/sentry-elixir#889) But this also relies on Phoenix 1.6. so we need to update that first
firestack
added a commit
to mbta/prediction_analyzer
that referenced
this pull request
Aug 29, 2025
this fails to compile on OTP 28 (getsentry/sentry-elixir#889) But this also relies on Phoenix 1.6. so we need to update that first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regexes cannot be part of module bodies in Erlang/OTP 28, so this PR adjusts the repository accordingly.
A new release with this fix would be appreciated, since Erlang/OTP 28 has just been released. :)