Introduce manual check-ins for crons #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
approved these changes
Feb 26, 2024
hkrutzer
reviewed
Feb 26, 2024
Comment on lines
+344
to
+347
| Check-ins are used to report the status of a monitor to Sentry. This is used | ||
| to track the health and progress of **cron jobs**. This function is somewhat | ||
| low level, and mostly useful when you want to report the status of a cron | ||
| but you are not using any common library to manage your cron jobs. |
There was a problem hiding this comment.
So this is basically meant to always be wrapped, right? As
{:ok, check_in_id} = Sentry.capture_check_in(status: :in_progress, monitor_slug: "genserver-job")
will break in e.g. testing code if no DSN is set.
There was a problem hiding this comment.
capture_check_in/1 will return :ignored if DSN is not set, yeah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at #694. This PR introduces the low-level API, without any integrations.