Add Sentry.Interfaces.Span
#679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
reviewed
Jan 2, 2024
lib/sentry/interfaces.ex
Outdated
| tags: map(), | ||
| trace_id: String.t() | nil, | ||
| op: String.t(), | ||
| contexts: Interfaces.context(), |
There was a problem hiding this comment.
Spans do not have contexts themselves in the protocol, in some SDKs this is held on the Transaction object as a reference and then merged into the top level contexts on the event payload.
It depends on implementation if you want to also have this reference here or not.
lib/sentry/interfaces.ex
Outdated
| spans: [t()], | ||
| status: String.t(), | ||
| data: map(), | ||
| fingerprint: [String.t()], |
There was a problem hiding this comment.
I don't see the fingerprint in the protocol either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the data structure.