Skip to content

Conversation

whatyouhide
Copy link
Collaborator

Closes #663.

If the goal of Sentry is to never get in the way and never cause issues itself, then maybe a better strategy here is to ignore unknown request keys instead of raising. I did some testing and it turns out that Sentry itself ignores unknown keys in the request interface, so this strategy seems solid.

@whatyouhide whatyouhide changed the title Ignores unknown request fields Ignore unknown request fields Dec 20, 2023
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes in general, we want to fail gracefully in the SDK as much as possible.

Order of priorities:

  • fail gracefully, never break user code (if monkeypatching - make sure they're idempotent)
  • collect correct data

@whatyouhide whatyouhide merged commit 989a684 into master Dec 20, 2023
@whatyouhide whatyouhide deleted the al/ignore-req-fields branch December 20, 2023 21:56
@Malian Malian mentioned this pull request Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in LiveView process
2 participants