Rename :before_send_event to :before_send (and hard-deprecate)
#649
Conversation
whatyouhide
changed the title
:before_send_event to :before_send (and hard-deprecate)
|
Isn't this a breaking change? ^^ |
|
Ahh this is for a major, got it 👍 |
| config :sentry, | ||
| before_send_event: {MyModule, :before_send}, | ||
| before_send: {MyModule, :before_send}, | ||
| after_send_event: {MyModule, :after_send} |
There was a problem hiding this comment.
Should we also rename this then? (It doesn't exist in other SDKs)
after_send_event
There was a problem hiding this comment.
@HazAT it doesn't exist in other SDKs as you said, and that's exactly why I left it untouched. It's one less change folks have to deal with. Honestly, I’m not even sure it's very much needed but hey, it's there 🤷 🙃
I'm not sure how standard of a term it is, but "hard-deprecate" would mean deprecate and emit a warning, while "soft-deprecate" would mean deprecate (in changelog) and hide in the docs, but without a warning. |
|
Hey, just read the changelog of v10 and found the use of https://github.com/getsentry/sentry-elixir#fingerprinting |
|
Hey @krns thanks for the catch! Fixed in |
This is in line with all other SDKs. Straight from the
commonsection of sentry-docs: