Fix Elixir 1.15 warnings #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinfarris
force-pushed
the
fix-warn-deprecation
branch
2 times, most recently
from
88d3084 to
751f4da
Compare
josevalim
reviewed
Jun 22, 2023
|
One tiny comment but otherwise LGTM! |
dustinfarris
force-pushed
the
fix-warn-deprecation
branch
2 times, most recently
from
0cf619d to
4928ac2
Compare
Elixir 1.15 hard-depcreates Logger.warn. Custom logger backends that still use the legacy custom backend API must translate the log level to avoid emitting a deprecation warning. Co-authored-by: José Valim <[email protected]>
dustinfarris
force-pushed
the
fix-warn-deprecation
branch
from
4928ac2 to
591a000
Compare
dustinfarris
changed the title
|
@antonpirker @sl0thentr0py this is ready for review. |
|
Great work! Lots of Elixir 1.15 adoption, so it would be awesome to get this merged in 🙃 |
|
@mitchellhenke @michallepicki still with Sentry? |
|
Please get this released 🙏🏻 🙇🏻 It's our current 1.15.2 upgrade blocker 🙂 |
Couldn't agree more 😅 |
mitchellhenke
approved these changes
Jul 7, 2023
jeregrine
approved these changes
Jul 7, 2023
|
will set aside some time for elixir next week, promise! |
whatyouhide
approved these changes
Jul 11, 2023
|
Sorry to be this guy but can we get a release for this? 😬 |
|
@anthonator don't be that guy... 😄 Just kidding. We merged this literally a few hours ago, we're working on a release, no worries! 🙃 |
|
😅 Sorry and thank you! 😅 |
derrickcrowne
pushed a commit
to blitzstudios/sentry-elixir
that referenced
this pull request
Oct 18, 2023
Elixir 1.15 hard-depcreates Logger.warn/1. Custom logger backends that still use the legacy custom backend API must translate the log level to avoid emitting a deprecation warning. Co-authored-by: José Valim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elixir 1.15 hard-deprecates Logger.warn. Custom logger backends that still use the legacy custom backend API must translate the log level to avoid emitting a deprecation warning.
Fixes #552