Skip to content

Conversation

isaacsanders
Copy link

Closes #522

@isaacsanders
Copy link
Author

@cleptric the CI seems broken, outside of my change.

@isaacsanders
Copy link
Author

I've tried fixing the CI, but it looks like it needs more help than I'm able to give right now.

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Feb 3, 2023

hey @isaacsanders finally looking at this, sorry for the delay.
If we include all metadata, should we maybe exclude the things listed here which are added by default?
Especially crash_reason which cannot be serialized as mentioned in #533 .

@isaacsanders
Copy link
Author

When is the soonest we know we can’t serialize something? If you want to start a list of things we exclude, we can start it here, but we could also move this to the request serialization part of the code.

@whatyouhide
Copy link
Collaborator

This is obsolete now that we merged #605. Thanks @isaacsanders 💟

@whatyouhide whatyouhide closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow metadata for logger backend to be :all
3 participants