Skip to content

Conversation

martosaur
Copy link
Contributor

@martosaur martosaur commented Jun 9, 2022

As per documentation

:excluded_domains - Any messages with a domain in the configured list will not be sent

However, when checking log message domains excluded_domain?/2 function only checks the head element.

This makes it impossible to exclude messages logged with default Elixir logger interface like Logger.error("Message", domain: [:custom_domain]) as their domain is always prepended with :elixir domain

@sl0thentr0py sl0thentr0py force-pushed the full_excluded_domain branch 2 times, most recently from 2170542 to d6c6074 Compare February 2, 2023 13:38
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @martosaur very late merge but better late than never

@sl0thentr0py sl0thentr0py merged commit ff7f148 into getsentry:master Feb 2, 2023
@martosaur martosaur deleted the full_excluded_domain branch February 2, 2023 17:08
@sonic182
Copy link

@sl0thentr0py Can you create a new release? I want to use this new code but a new package version is required 😄

@sonic182
Copy link

sonic182 commented Jun 8, 2023

@mitchellhenke or @michallepicki could you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants