Skip to content

Reduce Logger noise in HTTP Client #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 21, 2018
Merged

Reduce Logger noise in HTTP Client #274

merged 3 commits into from
Jun 21, 2018

Conversation

mitchellhenke
Copy link
Contributor

@mitchellhenke mitchellhenke commented Jun 18, 2018 •
edited
Loading

  • Refactor how logging works in the client to only print the entire body once
  • Make exponential backoff wait times explicit instead of computing
  • Fix unnecessary sleep
    Previous implementation was:
Try Request #1
Wait 2s
Try Request #2
Wait 4s
Try Request #3
Wait 8s
Try Request #4
Wait 16s

The last wait probably doesn't have a huge impact, but it kept the process alive longer than necessary, so it's been corrected.

Closes #271

@mitchellhenke mitchellhenke changed the title Improve retries sleepy Reduce Logger noise in HTTP Client Jun 18, 2018
@mitchellhenke mitchellhenke merged commit a321010 into master Jun 21, 2018
@mitchellhenke mitchellhenke deleted the improve-retries-sleepy branch June 21, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mitchellhenke