allow overriding handle_errors after using Sentry.Plug #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mention this in docs, as well as a fact that using Sentry.Plug does not retain Plug.ErrorHandler default behaviour of sending "Something went wrong" as a response (because Sentry.Plug does not call `super()` in it's handle_errors/2 implementation)
azhi
force-pushed
the
allow-overriding-handle-errors
branch
from
906cc68 to
3c3b891
Compare
|
Thanks for opening this, I’ll take a look soon! |
|
Thanks! 💖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mention this in docs, as well as a fact that using Sentry.Plug does not retain Plug.ErrorHandler default behaviour of sending "Something went wrong" as a response (because Sentry.Plug does not call
super()in it's handle_errors/2 implementation)