fix compile warning #248
Merged
fix compile warning #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeregrine
suggested changes
Jan 24, 2018
lib/sentry/event.ex
Outdated
| {pre_context, context, post_context} = | ||
| Sentry.Sources.get_source_context(@source_files, file, line_number) | ||
| @spec macro_put_source_context(map(), String.t(), integer()) :: map() | ||
| def macro_put_source_context(frame, file, line_number) do |
There was a problem hiding this comment.
make this private and rename it to "do_put_source_context" instead of macro. Its pretty common.
lib/sentry/event.ex
Outdated
| else | ||
| frame | ||
| end | ||
| Map.put(frame, :context_line, context) |
There was a problem hiding this comment.
Start this with frame |>
|
@jeregrine updated 🙂 |
jeregrine
reviewed
Jan 24, 2018
lib/sentry/event.ex
Outdated
| do_put_source_context(unquote(frame), unquote(file), unquote(line_number)) | ||
| end | ||
| else | ||
| frame |
There was a problem hiding this comment.
Do you need to quote this?
mitchellhenke
force-pushed
the
remove-warning
branch
from
d34a664 to
5d9ba35
Compare
|
@jeregrine updated 🙂 |
jeregrine
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation causes this warning because we're checking a compile-time module attribute at runtime, so the result is always the same. Looks like this:
Not super familiar with metaprogramming stuff, but this defines a macro that will either find and insert the source code context or return the frame as-is and remove the warning.