Modules #182
Merged
Modules #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeregrine
reviewed
Jul 5, 2017
test/event_test.exs
Outdated
| @@ -124,4 +124,16 @@ defmodule Sentry.EventTest do | |||
| }, | |||
| ]} == event.stacktrace | |||
| end | |||
|
|
|||
| test "transforms mix deps to map of modules" do | |||
| modify_env(:sentry, modules: Mix.Dep.cached()) | |||
There was a problem hiding this comment.
Ahh I don't know how I like this because it will fail whenever the deps change.
docs/config.rst
Outdated
| @@ -97,6 +97,10 @@ Optional settings | |||
|
|
|||
| Expects a list of modules that is used to distinguish among stacktrace frames that belong to your app and ones that are part of libraries or core Elixir. This is used to better display the significant part of stacktraces. The logic is greedy, so if your app's root module is ``MyApp`` and your setting is ``[MyApp]``, that module as well as any submodules like ``MyApp.Submodule`` would be considered part of your app. Defaults to ``[]``. | |||
|
|
|||
| .. describe:: modules | |||
|
|
|||
| Expects a map or a list of `%Mix.Dep{}` to report the loaded dependencies. To include all Mix dependencies, it can be set to `Mix.Dep.cached()`. | |||
There was a problem hiding this comment.
We probably need to say that it expects the modules to be in the same format as Mix.Dep.cached. I would almost prefer for us to call Mix.Dep.cached() at runtime to this.
There was a problem hiding this comment.
Unfortunately cannot call Mix.Dep.cached at runtime as a deployed application may be running without Mix
There was a problem hiding this comment.
Could we do a macro instead?
Also we could match on the type that Mix.Dep.cached returns and transform it, if it doesn't match just pass through?
jeregrine
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to figure something out for handling the case that Travis is running into
Closes #181