post event hook #175
Merged
post event hook #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeregrine
suggested changes
Jun 27, 2017
lib/sentry/client.ex
Outdated
| @@ -157,6 +163,22 @@ defmodule Sentry.Client do | |||
| {endpoint, public_key, secret_key} | |||
| end | |||
|
|
|||
| def maybe_call_after_send_event({:ok, _} = result, event) do | |||
| case Application.get_env(:sentry, :after_send_event) do | |||
There was a problem hiding this comment.
Can probably break this case into a function and use it for both scenarios instead of copying it.
There was a problem hiding this comment.
they each call the configured function differently because of different arities, so this makes less sense now right?
mitchellhenke
commented
Jun 27, 2017
lib/sentry/client.ex
Outdated
| @@ -157,6 +163,22 @@ defmodule Sentry.Client do | |||
| {endpoint, public_key, secret_key} | |||
| end | |||
|
|
|||
| def maybe_call_after_send_event({:ok, _} = result, event) do | |||
There was a problem hiding this comment.
@jeregrine Right now we only try to call the hook if the sending event was successful, but I was thinking since we're passing the result, we could call function.(result, event) and let the user decide so we can skip the logic on our side?
jeregrine
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166