Adding Fingerprint option to the event. #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeregrine
commented
May 23, 2017
| Sentry.capture_exception(my_exception) | ||
| Sentry.capture_exception(other_exception, [source_name: :my_source]) | ||
| Sentry.capture_exception(other_exception, [event_source: :my_source]) |
There was a problem hiding this comment.
I also noticed this was mispelled I THINK so I just fixed it.
jeregrine
commented
May 23, 2017
|
|
||
| stacktrace = Keyword.get(opts, :stacktrace, []) | ||
|
|
||
| fingerprint = Keyword.get(opts, :fingerprint, ["{{ default }}"]) |
There was a problem hiding this comment.
I'm not sure if we should ALWAYS send this up, or if sentry will ignore it if its fingerprint: nil or fingerprint: []
There was a problem hiding this comment.
Discussed in-person, but for posterity it seems other Sentry libraries do not send up a key/value for fingerprint if it's nil, so it would probably be best for us to do that too.
Currently we're directly encoding the Event struct to JSON, which is not ideal, and we'll need to not do that to fix the above issue. Created an issue for it here: #161
|
@mitchellhenke ping |
mitchellhenke
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for custom grouping https://docs.sentry.io/learn/rollups/\#custom-grouping