Avoid potential infinite loop when using a Sentry Logger backend #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and an exception occurs encoding Logger messages
|
Hey, thanks for opening this. I don't think this is something I'll be accepting unfortunately as it's probably better to make use of a custom HTTP client. It's not a well-documented feature, and I need to set up a behaviour for it to make it clear what the interface is, but the library allows you to define your own HTTP client and how it handles errors, retries, etc. I've opened #158 to improve that area of it. If you have any questions/issues around it, I'd be happy to help 🙂 |
|
@SimonWoolf worth posting in the issue about the infinite loop we hit today in production, or not necessarily relevant to this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if an exception occurs encoding a message